Page MenuHomeGitPull.it
Differential D119

Show lines without any arrival times separately
ClosedPublic
Actions

Authored by fabio.mazza on Jun 15 2023, 01:48.

Details

Reviewers
valerio.bozzolan
Maniphest Tasks
T1014: Reimplement arrivals list as recyclerView
Commits
R4:48005b4e1997: Show lines without any arrival times separately
Summary

Show the lines for which no arrivals are found at the bottom, with only the line name in a bubble. This is useful especially in the night to avoid taking up unnecessary space on the screen.

On the technical side:

  • Stop using listfragment as base for arrivals fragment
  • Use recyclerview for the arrival times

Diff Detail

Repository
R4 Libre BusTO
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 411
Build 588: BusTO Build Plan
Build 587: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Jun 15 2023, 01:48
Restricted Application added a project: Libre BusTO . · View Herald TranscriptJun 15 2023, 01:48
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 15 2023, 01:50
Harbormaster failed remote builds in B410: Diff 384!
gitpull.android.builder added a comment.Jun 15 2023, 08:35

Be bop be bop. I'm a bot. Builded:

→ D119-libre-busto.apk

sha256 62d746c6ecd93fb53e3caabbb3d12a7b745a3754465d7c3a4a5022c804ae2a76  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk
Harbormaster completed remote builds in B410: Diff 384.Jun 15 2023, 08:35
fabio.mazza requested review of this revision.Jun 15 2023, 08:35
fabio.mazza updated this revision to Diff 385.Jun 15 2023, 15:30
  • Try fixing stuff
  • Last try with constraint layout
  • Reuse trick of double linear layout
Harbormaster failed remote builds in B411: Diff 385!Jun 15 2023, 15:33
fabio.mazza updated this revision to Diff 386.Jun 15 2023, 15:49
  • Sort lines for no arrivals, remove unneeded separator
gitpull.android.builder added a comment.Jun 15 2023, 15:51

Be bop be bop. I'm a bot. Builded:

→ D119-libre-busto.apk

sha256 6ce2a49a728481181b3c63a420f14e583e290480c9f43a6615d3989e3ed2e08f  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk
Harbormaster completed remote builds in B412: Diff 386.Jun 15 2023, 15:51
fabio.mazza edited the summary of this revision. (Show Details)Jun 15 2023, 15:55
gitpull.android.builder added a comment.Jun 15 2023, 16:57

Be bop be bop. I'm a bot. Builded:

→ D119-libre-busto.apk

sha256 4d09fac8742d579dfae8eaa9e10a81c0fe7ff9a05807719f9ea3641a4168ab17  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk
Harbormaster completed remote builds in B411: Diff 385.Jun 15 2023, 16:57
valerio.bozzolan accepted this revision.Jun 15 2023, 17:26

Thanks

sgtm

This revision is now accepted and ready to land.Jun 15 2023, 17:26
Closed by commit R4:48005b4e1997: Show lines without any arrival times separately. · Explain WhyJun 15 2023, 18:07
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:48005b4e1997: Show lines without any arrival times separately.
valerio.bozzolan added a task: T1014: Reimplement arrivals list as recyclerView .Jun 17 2023, 11:42

Revision Contents
Changeset List

PathSize
app/
src/
main/
java/
it/
reyboz/
bustorino/
adapters/
6 lines
192 lines
48 lines
backend/
13 lines
fragments/
166 lines
2 lines
2 lines
33 lines
3 lines
util/
33 lines
res/
layout/
1 line
215 lines
37 lines
values-it/
2 lines
values/
1 line
2 lines
1 line

Diff 385

View Options

app/src/main/java/it/reyboz/bustorino/adapters/AdapterClickListener.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/adapters/PalinaAdapter.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/adapters/RouteOnlyLineAdapter.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/backend/Palina.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/FragmentHelper.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/ResultBaseFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/ResultListFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/util/ViewUtils.kt

Loading...
View Options

app/src/main/res/layout/entry_bus_line_passage.xml

Loading...
View Options

app/src/main/res/layout/fragment_arrivals.xml

Loading...
View Options

app/src/main/res/layout/round_line_header.xml

Loading...
View Options

app/src/main/res/values-it/strings.xml

Loading...
View Options

app/src/main/res/values/colors.xml

Loading...
View Options

app/src/main/res/values/dimens.xml

Loading...
View Options

app/src/main/res/values/strings.xml

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register