Details

Reviewers

valerio.bozzolan

Commits

R4:7f1ce7897acf: Better icon for notifications, avoid foreground service

Summary

Remove foreground service permission

Stop using singleton for MQTTClient, since each is bound to a service

Diff Detail

Repository

R4 Libre BusTO

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 517
Build 755: BusTO Build Plan
Build 754: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Feb 15 2024, 12:18

Restricted Application added a project: Libre BusTO . · View Herald TranscriptFeb 15 2024, 12:18

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript

Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript

fabio.mazza retitled this revision from Better icon for notifications, prepare for future changes to Better icon for notifications, put notification for MQTT.Feb 15 2024, 12:19

Be bop be bop. I'm a bot. Builded successfully ✨

D156-libre-busto.apk

sha256 0118743d3826358e864f2358221b9daf079f736116b0bf26d16ed184f4d2810c

Harbormaster completed remote builds in B517: Diff 487.Feb 15 2024, 12:21

fabio.mazza requested review of this revision.Feb 15 2024, 12:21

Actually declare foreground service permission

Harbormaster failed remote builds in B518: Diff 488!Feb 15 2024, 12:24

Be bop be bop. I'm a bot. Builded successfully ✨

D156-libre-busto.apk

sha256 33a18bfea938f29b9a4842585159f22368d8e6fa7efbef7d5f04be7d4ebe3aef

Harbormaster completed remote builds in B518: Diff 488.Feb 15 2024, 12:27

Use last version of MQTT library

Be bop be bop. I'm a bot. Builded successfully ✨

D156-libre-busto.apk

sha256 aba25b225a0b0d69b899fe770d1918223555ebb4a9c9433c7a051cbddc5c1f82

Harbormaster completed remote builds in B519: Diff 489.Feb 15 2024, 12:32

Remove foreground service

fabio.mazza edited the summary of this revision. (Show Details)Feb 15 2024, 15:44

fabio.mazza retitled this revision from Better icon for notifications, put notification for MQTT to Better icon for notifications, avoid foreground service.

Be bop be bop. I'm a bot. Builded successfully ✨

D156-libre-busto.apk

sha256 ac2ba8078a47bb6fd9fb06212253a3e8589f5baaac2912025827a57f5899ef2e

Harbormaster completed remote builds in B520: Diff 490.Feb 15 2024, 15:46

Don't reconnect when right after disconnect

Be bop be bop. I'm a bot. Builded successfully ✨

D156-libre-busto.apk

sha256 739a51068f536fc1e9d7c8a158fcebbd294943d36d2c6a702cb5899267ede39b

Harbormaster completed remote builds in B521: Diff 491.Feb 15 2024, 16:35

Remove removal of foreground service permission, is needed for WorkManager

Be bop be bop. I'm a bot. Builded successfully ✨

D156-libre-busto.apk

sha256 1d298c94caf450ba51817ba425c1500c5d83f272e15c9dd0614eae536d927eb5

Harbormaster completed remote builds in B522: Diff 492.Feb 15 2024, 16:52

sgtm

This revision is now accepted and ready to land.Feb 15 2024, 17:44

Closed by commit R4:7f1ce7897acf: Better icon for notifications, avoid foreground service. · Explain WhyFeb 16 2024, 12:24

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:7f1ce7897acf: Better icon for notifications, avoid foreground service.

Better icon for notifications, avoid foreground service
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 487

app/src/main/AndroidManifest.xml

app/src/main/java/it/reyboz/bustorino/backend/Notifications.java

app/src/main/java/it/reyboz/bustorino/backend/mato/MQTTMatoClient.kt

app/src/main/java/it/reyboz/bustorino/data/DBUpdateWorker.java

app/src/main/java/it/reyboz/bustorino/viewmodels/LivePositionsViewModel.kt

app/src/main/res/drawable/ic_bus_stilized.xml

app/src/main/res/drawable/ic_bus_stilized_transparent.xml

app/src/main/res/values-it/strings.xml

app/src/main/res/values/strings.xml

Better icon for notifications, avoid foreground serviceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 487

app/src/main/AndroidManifest.xml

app/src/main/java/it/reyboz/bustorino/backend/Notifications.java

app/src/main/java/it/reyboz/bustorino/backend/mato/MQTTMatoClient.kt

app/src/main/java/it/reyboz/bustorino/data/DBUpdateWorker.java

app/src/main/java/it/reyboz/bustorino/viewmodels/LivePositionsViewModel.kt

app/src/main/res/drawable/ic_bus_stilized.xml

app/src/main/res/drawable/ic_bus_stilized_transparent.xml

app/src/main/res/values-it/strings.xml

app/src/main/res/values/strings.xml

Better icon for notifications, avoid foreground service
ClosedPublic
Actions

Revision Contents
Changeset List