Page MenuHomeGitPull.it

Better icon for notifications, avoid foreground service
ClosedPublic

Authored by fabio.mazza on Feb 15 2024, 12:18.
Referenced Files
F2204542: D156.1721811380.diff
Tue, Jul 23, 10:56
Unknown Object (File)
Sun, Jul 21, 13:42
Unknown Object (File)
Sat, Jul 20, 17:31
Unknown Object (File)
Wed, Jul 17, 13:24
Unknown Object (File)
Mon, Jul 15, 04:28
Unknown Object (File)
Mon, Jul 15, 04:18
Unknown Object (File)
Mon, Jul 15, 04:17
Unknown Object (File)
Mon, Jul 15, 04:14

Details

Summary

Remove foreground service permission

Stop using singleton for MQTTClient, since each is bound to a service

Diff Detail

Repository
R4 Libre BusTO
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 519
Build 759: BusTO Build Plan
Build 758: arc lint + arc unit

Event Timeline

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
fabio.mazza retitled this revision from Better icon for notifications, prepare for future changes to Better icon for notifications, put notification for MQTT.Feb 15 2024, 12:19

Be bop be bop. I'm a bot. Builded successfully ✨

D156-libre-busto.apk

sha256 0118743d3826358e864f2358221b9daf079f736116b0bf26d16ed184f4d2810c
  • Actually declare foreground service permission

Be bop be bop. I'm a bot. Builded successfully ✨

D156-libre-busto.apk

sha256 33a18bfea938f29b9a4842585159f22368d8e6fa7efbef7d5f04be7d4ebe3aef
  • Use last version of MQTT library

Be bop be bop. I'm a bot. Builded successfully ✨

D156-libre-busto.apk

sha256 aba25b225a0b0d69b899fe770d1918223555ebb4a9c9433c7a051cbddc5c1f82
  • Remove foreground service
fabio.mazza retitled this revision from Better icon for notifications, put notification for MQTT to Better icon for notifications, avoid foreground service.

Be bop be bop. I'm a bot. Builded successfully ✨

D156-libre-busto.apk

sha256 ac2ba8078a47bb6fd9fb06212253a3e8589f5baaac2912025827a57f5899ef2e
  • Don't reconnect when right after disconnect

Be bop be bop. I'm a bot. Builded successfully ✨

D156-libre-busto.apk

sha256 739a51068f536fc1e9d7c8a158fcebbd294943d36d2c6a702cb5899267ede39b
  • Remove removal of foreground service permission, is needed for WorkManager

Be bop be bop. I'm a bot. Builded successfully ✨

D156-libre-busto.apk

sha256 1d298c94caf450ba51817ba425c1500c5d83f272e15c9dd0614eae536d927eb5
This revision is now accepted and ready to land.Feb 15 2024, 17:44