Page MenuHomeGitPull.it
Differential D17

Added favorites button
ClosedPublic
Actions

Authored by andrea.ugo on Mar 13 2020, 18:49.
Tags
Referenced Files
F2108840: D17.id68.diff
Fri, Apr 26, 10:42
F2108839: D17.id67.diff
Fri, Apr 26, 10:42
F2108838: D17.id66.diff
Fri, Apr 26, 10:42
F2108837: D17.id65.diff
Fri, Apr 26, 10:42
F2108836: D17.id64.diff
Fri, Apr 26, 10:42
F2108835: D17.id63.diff
Fri, Apr 26, 10:42
F2108834: D17.id62.diff
Fri, Apr 26, 10:42
F2108833: D17.id58.diff
Fri, Apr 26, 10:41
View All Files
Subscribers
Libre BusTO

Details

Reviewers
valerio.bozzolan
Maniphest Tasks
T18: Improve the "add to favorites" UX
Commits
R4:70f4fbba4c04: Added favorites button
R4:dd217f75eb0d: Kill ghost eating my brakets
R4:d4e0e9e27410: Fix DOS newlinesz
R4:1437b4e82a40: Fix DOS newlines
R4:e1170a190b9f: Fix what the hell I don't know what happened
R4:d3283f02e50a: Added favorites button
Summary

Added favorites button to fragment_list_view to add a stop to the favorites. Now there's a little star near the serched bus stop name to add it to the favorites.

Diff Detail

Repository
R4 Libre BusTO
Branch
arcpatch-D17_1
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 45
Build 63: BusTO Build Plan
Build 62: arc lint + arc unit

Event Timeline

andrea.ugo created this revision.Mar 13 2020, 18:49
Restricted Application added a project: Libre BusTO . · View Herald TranscriptMar 13 2020, 18:49
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added a subscriber: Libre BusTO . · View Herald Transcript
gitpull.android.builder added a comment.Mar 13 2020, 18:51

Be bop be bop. I'm a bot. Builded:

→ D17-libre-busto-unsigned.apk

Harbormaster completed remote builds in B31: Diff 49.Mar 13 2020, 18:51
andrea.ugo requested review of this revision.Mar 13 2020, 18:51
valerio.bozzolan added a task: T18: Improve the "add to favorites" UX.Mar 13 2020, 19:05
valerio.bozzolan updated this revision to Diff 50.Mar 13 2020, 19:23
  • restore Unix-like carriage return
gitpull.android.builder added a comment.Mar 13 2020, 19:23

Be bop be bop. I'm a bot. Builded:

→ D17-libre-busto-unsigned.apk

Harbormaster completed remote builds in B32: Diff 50.Mar 13 2020, 19:23
valerio.bozzolan added a comment.Mar 13 2020, 19:39

Well done, the star also works tapping on it! Here a screenshot:

Screenshot from 2020-03-13 19-35-36.png (798×520 px, 65 KB)

valerio.bozzolan mentioned this in R4:aaa981a1fb80: Add ability to check if a Bus Stop is in the favorites or not.Mar 13 2020, 20:36
valerio.bozzolan updated this revision to Diff 51.Mar 13 2020, 20:48
  • merge with master
gitpull.android.builder added a comment.Mar 13 2020, 20:49

Be bop be bop. I'm a bot. Builded:

→ D17-libre-busto-unsigned.apk

Harbormaster completed remote builds in B34: Diff 51.Mar 13 2020, 20:49
valerio.bozzolan updated this revision to Diff 54.Mar 14 2020, 16:22
  • add icons
Harbormaster failed remote builds in B37: Diff 54!Mar 14 2020, 16:23
valerio.bozzolan mentioned this in D18: Added 'Add To Favorites' star icons, fill and outline..Mar 14 2020, 16:23
andrea.ugo updated this revision to Diff 55.Mar 14 2020, 16:59

Corrected some issues.

Harbormaster failed remote builds in B38: Diff 55!Mar 14 2020, 17:00
andrea.ugo updated this revision to Diff 56.Mar 14 2020, 19:05
  • Changed repository
  • Finally the star fu**ing works
gitpull.android.builder added a comment.Mar 14 2020, 19:06

Be bop be bop. I'm a bot. Builded:

→ D17-libre-busto-unsigned.apk

Harbormaster completed remote builds in B39: Diff 56.Mar 14 2020, 19:06
andrea.ugo updated this revision to Diff 57.Mar 14 2020, 19:19
  • Finally the star fu**ing works
  • Remove unusefull file
Harbormaster failed remote builds in B40: Diff 57!Mar 14 2020, 19:20
andrea.ugo updated this revision to Diff 58.Mar 14 2020, 19:21
  • Remove unusefull files
Harbormaster failed remote builds in B41: Diff 58!Mar 14 2020, 19:21
andrea.ugo updated this revision to Diff 62.Mar 14 2020, 19:32
  • Correct 2 files
  • Correct file
Harbormaster failed remote builds in B42: Diff 62!Mar 14 2020, 19:32
andrea.ugo updated this revision to Diff 63.Mar 14 2020, 19:40
  • Correct 2 files
Harbormaster failed remote builds in B43: Diff 63!Mar 14 2020, 19:41
valerio.bozzolan updated this revision to Diff 64.Mar 14 2020, 19:45
  • Fix what the hell I don't know what happened
Harbormaster failed remote builds in B44: Diff 64!Mar 14 2020, 19:45
valerio.bozzolan updated this revision to Diff 65.Mar 14 2020, 19:47
  • Fix DOS newlines
Harbormaster failed remote builds in B45: Diff 65!Mar 14 2020, 19:47
valerio.bozzolan updated this revision to Diff 66.Mar 14 2020, 19:48
  • Fix DOS newlinesz
Harbormaster failed remote builds in B46: Diff 66!Mar 14 2020, 19:49
valerio.bozzolan updated this revision to Diff 67.Mar 14 2020, 19:50
  • Kill ghost eating my brakets
gitpull.android.builder added a comment.Mar 14 2020, 19:50

Be bop be bop. I'm a bot. Builded:

→ D17-libre-busto-unsigned.apk

Harbormaster completed remote builds in B47: Diff 67.Mar 14 2020, 19:50
valerio.bozzolan accepted this revision.Mar 14 2020, 19:55

A-W-E-S-O-M-E.

This revision is now accepted and ready to land.Mar 14 2020, 19:55
Closed by commit R4:d3283f02e50a: Added favorites button. · Explain WhyMar 14 2020, 19:59
This revision was automatically updated to reflect the committed changes.
valerio.bozzolan added a commit: R4:d3283f02e50a: Added favorites button.
valerio.bozzolan added a commit: R4:e1170a190b9f: Fix what the hell I don't know what happened.
valerio.bozzolan added a commit: R4:1437b4e82a40: Fix DOS newlines.
valerio.bozzolan added a commit: R4:d4e0e9e27410: Fix DOS newlinesz.
valerio.bozzolan added a commit: R4:dd217f75eb0d: Kill ghost eating my brakets.
andrea.ugo added a commit: R4:70f4fbba4c04: Added favorites button.Mar 14 2020, 20:03

Revision Contents
Changeset List

PathSize
1 line
res/
drawable-xxxhdpi/
16 lines
drawable/
9 lines
9 lines
layout/
44 lines
src/
it/
reyboz/
bustorino/
35 lines
fragments/
3 lines
30 lines

Diff 65

View Options

build.gradle

Loading...
View Options

gradlew.bat

Loading...
View Options

res/drawable-xxxhdpi/qrcode_button_custom.xml

Loading...
View Options

res/drawable/ic_star_filled.xml

Loading...
View Options

res/drawable/ic_star_outline.xml

Loading...
View Options

res/layout/fragment_list_view.xml

Loading...
View Options

res/layout/stop_card.xml

Loading...
View Options

src/it/reyboz/bustorino/ActivityMain.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/ArrivalsFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/ResultListFragment.java

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register