Project Tags

Referenced Files

	F13391365: D249.1780168332.diff
	Fri, May 29, 21:12

	F13391025: D249.1780157041.diff
	Fri, May 29, 18:04

	F13390161: D249.1780128506.diff
	Fri, May 29, 10:08

	F13382680: IMG_20260527_200939_399.jpg
	Wed, May 27, 20:10

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

Libre BusTO hackers

Maniphest Tasks

T1270: Add dark theme

Commits

R4:fdb447f66ffb: Make dark theme for the app, fix stuck nearby on reopen

Summary

Make dark theme work revising colors and layouts (fix T1270)

Adjust map theme

Update vehicle informations

Fix stuck nearby fragment on reopen

Test Plan

Open settings, select Dark theme. Enjoy!

Diff Detail

Repository

R4 Libre BusTO

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Tue, May 26, 20:41

Restricted Application added a project: Libre BusTO. · View Herald TranscriptTue, May 26, 20:41

Restricted Application added a reviewer: Libre BusTO hackers. · View Herald Transcript

Restricted Application added a subscriber: valerio.bozzolan. · View Herald Transcript

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D249-arm64-v8a-signed.apk
sha256: 4efa79524cd963515103ec64253bc31d808ff0a48046521f3764bb5703b53ce6

APK for armeabi-v7a: D249-armeabi-v7a-signed.apk
sha256: 3a81e863c71dc11cbe88fce2afc27a55399769447d19c5091c139778a6950598

APK for universal: D249-universal-signed.apk
sha256: 959c89558d018012036305da6cc290570c964264e432fd5b1a76d114cf85b9d8

APK for x86: D249-x86-signed.apk
sha256: dae990d955441017ae02b08cb5a6fedf8268f3b8c2d6605bf3877ac01bc9ceda

APK for x86_64: D249-x86_64-signed.apk
sha256: 144954fa38bccb74ff391d3dc5bcc2e07aafc16c5db3af71b6ce9efed394ac8d

Harbormaster completed remote builds in B933: Diff 797.Tue, May 26, 20:47

fabio.mazza requested review of this revision.Tue, May 26, 20:47

Update theme on preference update

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D249-arm64-v8a-signed.apk
sha256: 50db7c69112a882438b8be693b1a8f02bb44055f843ed728be5f9c5efca9d22d

APK for armeabi-v7a: D249-armeabi-v7a-signed.apk
sha256: 3f9932051f07708434678c32603ebf00dfe5893583aacf4218664872842b516e

APK for universal: D249-universal-signed.apk
sha256: 1a312fdc57b929b5e659b9fc76aff17dba667ab985b1be996fcdcf6ac2c7e6d8

APK for x86: D249-x86-signed.apk
sha256: ae1b3e51e10d75c22feb25ab33fd34c833d46fe64300772cf7ecc42323079f4f

APK for x86_64: D249-x86_64-signed.apk
sha256: 98df805021b551b2e2813f70d4eec7c8cc0263c8885a3e4320feef64842a88ea

Harbormaster completed remote builds in B934: Diff 798.Tue, May 26, 21:08

Rename
Change file

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D249-arm64-v8a-signed.apk
sha256: 024f9b4eb6eb551570ff46d2f8bf63064b851e449adb75edc69bbb484ced7470

APK for armeabi-v7a: D249-armeabi-v7a-signed.apk
sha256: 1686947969ff594abc5f69250184eeb5d7a6eb3d85c4cce2dff8e8d97a2e6321

APK for universal: D249-universal-signed.apk
sha256: df004150e2ef10e522bb3f82183e5bc254957dd2d116d5e759300aa4a1b58884

APK for x86: D249-x86-signed.apk
sha256: bb18f57d7a390cde74919293e8327ac4cc3a8e1c30181b79513be1f146caa16b

APK for x86_64: D249-x86_64-signed.apk
sha256: 2c25e18585597fab4e23ce0c008494c773b25ea269554920893b96d5c06ffe8a

Harbormaster completed remote builds in B935: Diff 799.Wed, May 27, 11:55

Add more bus info
Merge branch 'master' into arcpatch-D249
Fix arrivals
Map changes (really small)
Change text color
Fix color for arrivals card border

fabio.mazza edited the summary of this revision. (Show Details)Wed, May 27, 19:18

fabio.mazza edited the summary of this revision. (Show Details)

fabio.mazza edited the test plan for this revision. (Show Details)

fabio.mazza edited the summary of this revision. (Show Details)

fabio.mazza added a task: T1270: Add dark theme.

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D249-arm64-v8a-signed.apk
sha256: 7c20fb84395048a9bc86714785d4f149575c9f9e0c7c1dd00ad9699913e10a69

APK for armeabi-v7a: D249-armeabi-v7a-signed.apk
sha256: 04b0c288f64944a77bf48a7a0145ce29a6c615a5649e848476a4bbfdf2238c37

APK for universal: D249-universal-signed.apk
sha256: eb25b2f61ede6a58e40f1c42b98b823ed592885c6dfc7865003ccd19606443f4

APK for x86: D249-x86-signed.apk
sha256: 6e3246ac6eefcab3accad6547da895a28700026a202e4a521b118783c8910082

APK for x86_64: D249-x86_64-signed.apk
sha256: f7a1033bc89947e1039d3cf2de6505aef4b8f0128816666c1eab18f4b3f866b4

Harbormaster completed remote builds in B937: Diff 801.Wed, May 27, 19:23

Fix other buttons
Small change

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D249-arm64-v8a-signed.apk
sha256: 6bd4de7cc62717c484077686d4042c72e18047166b1a263e741ba5260c763cbc

APK for armeabi-v7a: D249-armeabi-v7a-signed.apk
sha256: 7236f64289027d9ee89286d5c6f0b88aa0db173264bb97a4ef80bb29e5e19a4c

APK for universal: D249-universal-signed.apk
sha256: 06aece4135d5033580d4d6de4114e5490d8986436482c875e6acf9846c77a6e7

APK for x86: D249-x86-signed.apk
sha256: f5fd95f918fad33ed83d00edc1b2ce011efff18c6bb26aa75fa530aafa29b990

APK for x86_64: D249-x86_64-signed.apk
sha256: d325c47e2841831ba2b54ea4051c7f1e6abdda8a1a45daed870db31a947ee5ba

Harbormaster completed remote builds in B938: Diff 802.Wed, May 27, 19:45

NIIICE

Small thing: black on black text:

IMG_20260527_200939_399.jpg (580×1,280 px, 89 KB)

This revision is now accepted and ready to land.Wed, May 27, 20:10

Adjust trams and bus and metro icons
Fix bug not showing bus selected
Adjust nearby arrivals card
Improve null handling
Apply theme change inside the settings

This revision now requires review to proceed.Thu, May 28, 12:43

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D249-arm64-v8a-signed.apk
sha256: dbee097e7fad43cf2adc440e3b9b17c1af740997fb10e254c2240107fe867c90

APK for armeabi-v7a: D249-armeabi-v7a-signed.apk
sha256: e27f2a7bc276aca37c2f0871a12eb3176b3a706a59e795e658a9310b7b49f39b

APK for universal: D249-universal-signed.apk
sha256: c468bd9c2ef23d9c6dfc76512e88042eff95e30fbe53d81a786dbadd3126e103

APK for x86: D249-x86-signed.apk
sha256: 143025397d08b0636bfa2f276fa4ee6b10f1f3c05086e51349e858980bda48cd

APK for x86_64: D249-x86_64-signed.apk
sha256: f338a5509582eef7be390b9b15b4c96f67e2c69fbd360196a54f926b9ca902b7

Harbormaster completed remote builds in B939: Diff 803.Thu, May 28, 12:48

Fix text color in About Activity

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D249-arm64-v8a-signed.apk
sha256: aa986acbb0bc94592299d3d0dfa443861c7b4cbaf2c2def1434895a80cfaac1d

APK for armeabi-v7a: D249-armeabi-v7a-signed.apk
sha256: adb0d0a996870378370ba3657ff42d73ceb7d019dac4b33f4ece739eaa3e3c0a

APK for universal: D249-universal-signed.apk
sha256: 443b34b88234ea2d23328827be1431b2bacca7397eba14040f5cf8ad5c5b2702

APK for x86: D249-x86-signed.apk
sha256: d9eb686b78c4b94f9139fe1301f92afaf2f10c3a6119a9e0c8c1bf93225860d8

APK for x86_64: D249-x86_64-signed.apk
sha256: 017e343c0f9aa52c0f23859a411990dbd1aa67bd3382155dabc358ee1e5151a8

Harbormaster completed remote builds in B940: Diff 804.Thu, May 28, 12:54

Now ready for approval

I forgot a few Text views asd

Fix missing view
Fix recreating activity bug

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D249-arm64-v8a-signed.apk
sha256: af4b1f8f2b8d58d2260384093c579762994935db1f4a97a03ebae503d4da9028

APK for armeabi-v7a: D249-armeabi-v7a-signed.apk
sha256: dfb214168218ef358abe1e4404d16b981cab33daa4d0ea33cc3b2ec13b5bd0b8

APK for universal: D249-universal-signed.apk
sha256: ea8976c811bb30c3a9fa593a3e1a31cab330c67308d2b6d4ade6ea01dc1dec27

APK for x86: D249-x86-signed.apk
sha256: de2129bdf77b805a8949f64c1355e541f5629496b2fbcab4363d2747042abc0a

APK for x86_64: D249-x86_64-signed.apk
sha256: fcf22b1638c2f704fae054172d9601438efbf1c11e0f021a77418a32bc4ca63e

Harbormaster completed remote builds in B941: Diff 805.Thu, May 28, 15:34

In D249#5547, @fabio.mazza wrote:

Now ready for approval

Now? asd

Fix visualization artifacts

Ok, modifications done, test it (exploring different screens, going back and forth) and if it's all ok approve

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D249-arm64-v8a-signed.apk
sha256: eb20b693c82a8d08e1076a35c386bb1d368043a3be7db21ce2901dd33ce07683

APK for armeabi-v7a: D249-armeabi-v7a-signed.apk
sha256: 0980cc1c784eaeebce0e6461653b926f22ff0b3a73387c601a258fff41ff4ba5

APK for universal: D249-universal-signed.apk
sha256: 5aa7757ca9712aa61ca9cbebef846cdcb0db50ae0627f24404f0129717a0be43

APK for x86: D249-x86-signed.apk
sha256: 236e357abcf35012b20c88dcf0a66ca18f3c167e7d92701be925388ad6efa4b3

APK for x86_64: D249-x86_64-signed.apk
sha256: f10df89b3d10b1f9b35c0975b58370d2241731ec4a06ecc2bacd93928fc172e5

Harbormaster completed remote builds in B942: Diff 806.Thu, May 28, 15:46

Fix crash on change

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D249-arm64-v8a-signed.apk
sha256: fcfb6445118004e08ce5edfec6c65327772eaa53bdcb1237b12cef9a6b45cbf3

APK for armeabi-v7a: D249-armeabi-v7a-signed.apk
sha256: 1e921cb3f0c91b81dbe3d36408f19c5f14be5e81df30505e79e52e255ebbd6ec

APK for universal: D249-universal-signed.apk
sha256: 93db65b61edf918ebdee412d31131dd1aef940601cc6d53c2f5a039ea3444cc9

APK for x86: D249-x86-signed.apk
sha256: 308db7f42fa27deb6481a3a5fb2b9a0bdfeb6e7c48eab777427f144cc2bec150

APK for x86_64: D249-x86_64-signed.apk
sha256: 142d6f3c62cc176e02698bcfc3d430567aca475cff1a0277d9ba5f24adfdc887

Harbormaster completed remote builds in B943: Diff 807.Thu, May 28, 16:28

Indicate 18m vehicles

fabio.mazza added a comment.Thu, May 28, 16:47

This comment was removed by fabio.mazza.

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D249-arm64-v8a-signed.apk
sha256: 5c58515ebcdde3b97dc8ce8321f446e16385adacbf4513812ff69a006084f8fc

APK for armeabi-v7a: D249-armeabi-v7a-signed.apk
sha256: 84f1e2ed3b3b0ee854863ef4609073783aa8fc95ab5b14e485cf4136b0f98cf4

APK for universal: D249-universal-signed.apk
sha256: eebdfeb7f97eedca6fe616a57d8389e9d12de1f06c62564a4430050064c60b63

APK for x86: D249-x86-signed.apk
sha256: 37e33a993884306e8d4d1bc2850758fd087a72376f2f7ed2b03247e5e1139478

APK for x86_64: D249-x86_64-signed.apk
sha256: ea7a8f42fe3d34a22692ee924e115b5ebdea17f721f78a6e48d860807ee1c9f2

Harbormaster completed remote builds in B944: Diff 808.Thu, May 28, 16:51

One DialogFragment does not work in Dark mode

Fix background color of dialog

Test and accept

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D249-arm64-v8a-signed.apk
sha256: 08453ee6c44736186fa4c3c67d0d6ae8813553b8bb773c17ae758d1ae2aa33fd

APK for armeabi-v7a: D249-armeabi-v7a-signed.apk
sha256: 802bb8e2d43cb3c61c7a1e276bc86c9d5d35b88a978ee3d6a84d721f5b0fe8a0

APK for universal: D249-universal-signed.apk
sha256: b998ab2b0d81a74f527507504f05c9864a7c1bd8bb179d06e8704da97c50642a

APK for x86: D249-x86-signed.apk
sha256: 13231eb6b4069097f1b0464efb6fd26b5a05f81254b6148c4e05bf31ad2dfb65

APK for x86_64: D249-x86_64-signed.apk
sha256: 74fb0bf4c6909c68946bb499831f340560f905bdf1c633e9ac48e8207d2990bb

Harbormaster completed remote builds in B945: Diff 809.Thu, May 28, 17:15

I love this :3

This revision is now accepted and ready to land.Thu, May 28, 19:10

Closed by commit R4:fdb447f66ffb: Make dark theme for the app, fix stuck nearby on reopen. · Explain WhyThu, May 28, 23:08

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:fdb447f66ffb: Make dark theme for the app, fix stuck nearby on reopen.

Make dark theme for the app, fix stuck nearby on reopenClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 810

app/src/main/AndroidManifest.xml

app/src/main/assets/versatiles_eclipse_modif.json

app/src/main/java/it/reyboz/bustorino/ActivityIntro.kt

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

app/src/main/java/it/reyboz/bustorino/BustoApp.java

app/src/main/java/it/reyboz/bustorino/adapters/ArrivalsStopAdapter.java

app/src/main/java/it/reyboz/bustorino/adapters/PalinaAdapter.java

app/src/main/java/it/reyboz/bustorino/adapters/SquareStopAdapter.java

app/src/main/java/it/reyboz/bustorino/adapters/StopAdapter.java

app/src/main/java/it/reyboz/bustorino/adapters/StopRecyclerAdapter.java

app/src/main/java/it/reyboz/bustorino/backend/KotlinUtils.kt

app/src/main/java/it/reyboz/bustorino/backend/VehicleUtils.kt

app/src/main/java/it/reyboz/bustorino/data/GtfsMaintenanceWorker.kt

app/src/main/java/it/reyboz/bustorino/data/PreferencesHolder.java

app/src/main/java/it/reyboz/bustorino/fragments/GeneralMapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/LivePositionsDialogFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/NearbyStopsFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/SettingsFragment.java

app/src/main/java/it/reyboz/bustorino/map/MapLibreUtils.kt

app/src/main/java/it/reyboz/bustorino/middleware/GeneralActivity.java

app/src/main/res/drawable-hdpi/ic_center_map.png

app/src/main/res/drawable-hdpi/ic_follow_me_on.png

app/src/main/res/drawable-mdpi/ic_center_map.png

app/src/main/res/drawable-mdpi/ic_follow_me_on.png

app/src/main/res/drawable-xhdpi/ic_center_map.png

app/src/main/res/drawable-xhdpi/ic_follow_me_on.png

app/src/main/res/drawable-xxhdpi/ic_center_map.png

app/src/main/res/drawable-xxhdpi/ic_follow_me_on.png

app/src/main/res/drawable-xxxhdpi/bus.png

app/src/main/res/drawable-xxxhdpi/ic_center_map.png

app/src/main/res/drawable-xxxhdpi/ic_follow_me_on.png

app/src/main/res/drawable-xxxhdpi/subway.png

app/src/main/res/drawable-xxxhdpi/tram.png

app/src/main/res/drawable/bottom_sheet_background.xml

app/src/main/res/drawable/bus_stop_new.xml

app/src/main/res/drawable/bus_stop_new_highlight.xml

app/src/main/res/drawable/ic_bus.xml

app/src/main/res/drawable/ic_bus_electric_filled.xml

app/src/main/res/drawable/ic_bus_electric_small.xml

app/src/main/res/drawable/ic_bus_material.xml

app/src/main/res/drawable/ic_bus_stilized.xml

app/src/main/res/drawable/ic_subway_filled.xml

app/src/main/res/drawable/ic_tram_filled_24.xml

app/src/main/res/drawable/ic_tram_material.xml

app/src/main/res/drawable/magnifying_glass_larger.xml

app/src/main/res/drawable/map_bus_position_icon_sel.xml

app/src/main/res/layout/activity_about.xml

app/src/main/res/layout/activity_principal.xml

app/src/main/res/layout/arrivals_nearby_card.xml

app/src/main/res/layout/default_toobar.xml

app/src/main/res/layout/entry_alert_line_adapter.xml

app/src/main/res/layout/entry_bus_line_passage.xml

app/src/main/res/layout/entry_bus_stop.xml

app/src/main/res/layout/fragment_dialog_alerts_line.xml

app/src/main/res/layout/fragment_dialog_buspositions.xml

app/src/main/res/layout/fragment_intro.xml

app/src/main/res/layout/fragment_lines_detail.xml

app/src/main/res/layout/fragment_lines_grid.xml

app/src/main/res/layout/fragment_nearby_stops.xml

app/src/main/res/layout/include_map_bottom_sheet.xml

app/src/main/res/layout/item_arrivals_nearby_card.xml

app/src/main/res/layout/item_card_button.xml

app/src/main/res/layout/item_stop_nearby_card.xml

app/src/main/res/layout/stop_card.xml

app/src/main/res/values-it/strings.xml

app/src/main/res/values-night/colors.xml

app/src/main/res/values-night/themes.xml

app/src/main/res/values/colors.xml

app/src/main/res/values/keys.xml

app/src/main/res/values/strings.xml

app/src/main/res/values/styles.xml

app/src/main/res/values/theme.xml

app/src/main/res/xml/preferences.xml

Make dark theme for the app, fix stuck nearby on reopen
ClosedPublic
Actions

Revision Contents
Changeset List