Page MenuHomeGitPull.it

Add user position to the map!
ClosedPublic

Authored by fabio.mazza on Jul 12 2020, 19:27.

Details

Summary

Add user position to the map:

  • I have used a FolderOverlay, which groups together all the stops Markers, so that only them get thrown away at each load, and the user position stays. It would be much better to just load them all on the map, but that probably takes too much memory.... Or well, manually decide which markers to throw away and which markers to create when the user moves the map around (which might be a LOT better for the performance)
  • Use app context for the AppLocationManager, so to avoid memory leaks
Test Plan

check if builds correctly

Diff Detail

Repository
R4 Libre BusTO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 100
Build 144: BusTO Build Plan
Build 143: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Jul 12 2020, 19:27
Restricted Application added a project: Libre BusTO . · View Herald TranscriptJul 12 2020, 19:27
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript

Be bop be bop. I'm a bot. Builded:

D35-libre-busto-unsigned.apk

fabio.mazza requested review of this revision.Jul 12 2020, 19:29
fabio.mazza edited the summary of this revision. (Show Details)Jul 12 2020, 19:35
fabio.mazza edited the summary of this revision. (Show Details)
valerio.bozzolan accepted this revision.Jul 13 2020, 22:39

Just a question. Why every damn default feature introduced in OSMDroid must look like Android 3?

Anyway, good job man.

This revision is now accepted and ready to land.Jul 13 2020, 22:39
This revision was automatically updated to reflect the committed changes.