Project Tags

Referenced Files

	F13292336: D234.1778088332.diff
	Tue, May 5, 19:25

	F13292016: D234.1778080487.diff
	Tue, May 5, 17:14

	F13292015: D234.1778080455.diff
	Tue, May 5, 17:14

	F13292011: D234.1778080401.diff
	Tue, May 5, 17:13

	F13291932: D234.1778075526.diff
	Tue, May 5, 15:52

	F13291905: D234.1778074022.diff
	Tue, May 5, 15:27

	F13281756: image.png
	Thu, Apr 30, 11:44

	F13281755: image.png
	Thu, Apr 30, 11:44

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

Libre BusTO hackers

Maniphest Tasks

T1165: Use Alerts functionality by GTFS

Commits

R4:6e383fd97f1f: Download GTFS RT Alerts and show them in the lines screen

Summary

Show the GTFS Alerts in a Line screen, opening a dialog in the process.
Also, cache the Alerts on the device using Room, deleting them after 24hrs.

Screenshots:

Fix T1165

Test Plan

Open lines, select 10
Check that there is a "notification"-like icon to press (which should be)
Press the icon and see

Diff Detail

Repository

R4 Libre BusTO

Branch

gtfsalerts

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 853
Build 1239: BusTO Build Plan
Build 1238: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Tue, Apr 28, 19:01

Restricted Application added a project: Libre BusTO. · View Herald TranscriptTue, Apr 28, 19:01

Restricted Application added a reviewer: Libre BusTO hackers. · View Herald Transcript

Restricted Application added a subscriber: valerio.bozzolan. · View Herald Transcript

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D234-arm64-v8a-signed.apk
sha256: c7312f64749c9d5857e65662306f348cf8413910ab6d604e4be8dbc4ff14b290

APK for armeabi-v7a: D234-armeabi-v7a-signed.apk
sha256: 41141d9fdd1f818b57a7597e02ffa1b20f4bdbdf93225b6c483e0c37b243fd9f

APK for universal: D234-universal-signed.apk
sha256: 211281cbcca7f28b25acbd837aca30688ff53eb5c23c191ecd19a9124a1a18f6

APK for x86: D234-x86-signed.apk
sha256: 30ace09bcee810fd9d0a28cbb77c5cc9aa8102963e4a4f2b3dc1c6cedb355348

APK for x86_64: D234-x86_64-signed.apk
sha256: 672edb518d4fe29a6559d22a3761a94f69f3aeb3ca96ac52b90fdccc29e1774e

Harbormaster completed remote builds in B849: Diff 720.Tue, Apr 28, 19:06

fabio.mazza requested review of this revision.Tue, Apr 28, 19:06

Marking as "not finished yet"

This revision now requires changes to proceed.Wed, Apr 29, 19:02

More info print
Show alerts in Dialog, finally
Delete previous older than 24 hours

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D234-arm64-v8a-signed.apk
sha256: 040cbe70e2b542226ba6c3e807cf3ea879c54f404953e7be30d1fa13a2668b64

APK for armeabi-v7a: D234-armeabi-v7a-signed.apk
sha256: 0eda66c21723a8b115995cf965cd0a7296cd9256cbb5920a9c9ae0916aff0954

APK for universal: D234-universal-signed.apk
sha256: 6d9c8204af018ced4792e13b562d4cf11034f3377cde0d6666e2fad9f262402b

APK for x86: D234-x86-signed.apk
sha256: d3b9ce81138b0dfa6c32753b348f5913e92e567544d3b8cf2b7aa50e82e0df8c

APK for x86_64: D234-x86_64-signed.apk
sha256: d0fa56222fd7c4332f000aa08da67e6c03d1f13f745f2f4f865e3e9c3b715343

Harbormaster completed remote builds in B850: Diff 721.Wed, Apr 29, 20:26

Fix layout and setValue/postValue

fabio.mazza retitled this revision from Download GTFS RT Alerts (not finished yet) to Download GTFS RT Alerts.Wed, Apr 29, 20:37

fabio.mazza edited the summary of this revision. (Show Details)

fabio.mazza edited the test plan for this revision. (Show Details)

fabio.mazza edited the summary of this revision. (Show Details)

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D234-arm64-v8a-signed.apk
sha256: 7a015059e7588e860b0767d55f4d074c8d91e00ab7e862948d8ee917f4e32163

APK for armeabi-v7a: D234-armeabi-v7a-signed.apk
sha256: 9d4f77166805d6d96440feebb390bd813f8aec0ec74af3a71fe9357dd3db01e6

APK for universal: D234-universal-signed.apk
sha256: 861778197b4c077f67174cbb99a44457e3dff4124f8643eb1da3f3b3103324d5

APK for x86: D234-x86-signed.apk
sha256: 32bac908a821c2d9ad638f1652305f7671418ad32c85db5dd2c96371cdd55a81

APK for x86_64: D234-x86_64-signed.apk
sha256: 128ad1beca7ee0288967b6c18fadbb2cdf9115543ec104aa3a5ff760105cc0d3

Harbormaster completed remote builds in B851: Diff 722.Wed, Apr 29, 20:40

fabio.mazza edited the summary of this revision. (Show Details)Wed, Apr 29, 20:42

fabio.mazza added a task: T1165: Use Alerts functionality by GTFS.

fabio.mazza retitled this revision from Download GTFS RT Alerts to Download GTFS RT Alerts and show them in the lines screen.Wed, Apr 29, 20:50

Sto testando ma non li vedo - Dove dovrebbero comparire? :3

valerio.bozzolan edited the summary of this revision. (Show Details)Thu, Apr 30, 11:44

In D234#4956, @valerio.bozzolan wrote:

Sto testando ma non li vedo - Dove dovrebbero comparire? :3

L'app li scarica in background, ma a volte il server della GTT risponde con 0 avvisi oppure non risponde proprio.

Una volta che sono scaricati, dovresti vedere dentro la schermata della 10 che ci sono

business-dance

This revision is now accepted and ready to land.Thu, Apr 30, 11:45

fabio.mazza edited the summary of this revision. (Show Details)Thu, Apr 30, 11:45

Fix check for alerts

This revision now requires review to proceed.Thu, Apr 30, 15:30

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D234-arm64-v8a-signed.apk
sha256: 71470cf67023cc5d638fd1d2e80c7d8958fdfae0f3c0aad7cfdf2ed5a8bef927

APK for armeabi-v7a: D234-armeabi-v7a-signed.apk
sha256: 4cc7e07168cb8bc78143de1b8b1e97e73caf3cf80c810de6dc58dd2de0fd8c23

APK for universal: D234-universal-signed.apk
sha256: 9397bce0940e9b62652948549b53595d7142320fe27fe3a768fd959ed06e86ad

APK for x86: D234-x86-signed.apk
sha256: 582a7a7b15c976413cb2bfe23ae7b20d29ad7000952988aff0d219cb5e0dced8

APK for x86_64: D234-x86_64-signed.apk
sha256: ee134563f531db37559ef262fc521bab244da15073ac9728bc7f81ab2c161a2d

Harbormaster completed remote builds in B853: Diff 724.Thu, Apr 30, 15:36

Use lower minutes check, less logcat output

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D234-arm64-v8a-signed.apk
sha256: 3337712f00e0a3b317f5febaa9575aeeb4b3dd83a6e4da5a6c4a3abe7a858ad5

APK for armeabi-v7a: D234-armeabi-v7a-signed.apk
sha256: fa61c508d2a4346fce49839fe77f0074aaf0105078def3285d43530a3e6a08c2

APK for universal: D234-universal-signed.apk
sha256: 62c0a99845586ba38f7beb92cd9e28215537cd95ca79f70aa87775f14c8cf4a9

APK for x86: D234-x86-signed.apk
sha256: 1c1ae46244bc9feab9cfc6230c9b373599de0a4940c745634879f11511763a99

APK for x86_64: D234-x86_64-signed.apk
sha256: 2c822082d58109952ce4c60d1469ac9b0c5a8e597832c15b444475bcf0e003a4

Harbormaster completed remote builds in B854: Diff 725.Thu, Apr 30, 16:10

So far, so good - love it

This revision is now accepted and ready to land.Thu, Apr 30, 19:28

Closed by commit R4:6e383fd97f1f: Download GTFS RT Alerts and show them in the lines screen. · Explain WhyThu, Apr 30, 20:02

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:6e383fd97f1f: Download GTFS RT Alerts and show them in the lines screen.

Download GTFS RT Alerts and show them in the lines screen
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 724

app/src/main/java/it/reyboz/bustorino/ActivityExperiments.java

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

app/src/main/java/it/reyboz/bustorino/adapters/AlertLineFullAdapter.kt

app/src/main/java/it/reyboz/bustorino/backend/Notifications.java

app/src/main/java/it/reyboz/bustorino/backend/gtfs/GtfsRtAlertsRequest.kt

app/src/main/java/it/reyboz/bustorino/backend/gtfs/GtfsRtPositionsRequest.kt

app/src/main/java/it/reyboz/bustorino/backend/gtfs/GtfsUtils.java

app/src/main/java/it/reyboz/bustorino/data/GtfsAlertDBDownloadWorker.kt

app/src/main/java/it/reyboz/bustorino/data/GtfsRepository.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/AlertsDao.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/Converters.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsAlertsDBConverter.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsDatabase.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsRtAlerts.kt

app/src/main/java/it/reyboz/bustorino/fragments/AlertsDialogFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/AlertsFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/LinesGridShowingViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/LinesViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/ServiceAlertsViewModel.kt

app/src/main/res/drawable/chat_bubble_warning_solid.xml

app/src/main/res/drawable/refresh_line.xml

app/src/main/res/layout/entry_alert_line_adapter.xml

app/src/main/res/layout/fragment_alerts.xml

app/src/main/res/layout/fragment_dialog_alerts_line.xml

app/src/main/res/layout/fragment_dialog_buspositions.xml

app/src/main/res/layout/fragment_lines_detail.xml

app/src/main/res/values-it/strings.xml

app/src/main/res/values/dimens.xml

app/src/main/res/values/strings.xml

Download GTFS RT Alerts and show them in the lines screenClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 724

app/src/main/java/it/reyboz/bustorino/ActivityExperiments.java

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

app/src/main/java/it/reyboz/bustorino/adapters/AlertLineFullAdapter.kt

app/src/main/java/it/reyboz/bustorino/backend/Notifications.java

app/src/main/java/it/reyboz/bustorino/backend/gtfs/GtfsRtAlertsRequest.kt

app/src/main/java/it/reyboz/bustorino/backend/gtfs/GtfsRtPositionsRequest.kt

app/src/main/java/it/reyboz/bustorino/backend/gtfs/GtfsUtils.java

app/src/main/java/it/reyboz/bustorino/data/GtfsAlertDBDownloadWorker.kt

app/src/main/java/it/reyboz/bustorino/data/GtfsRepository.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/AlertsDao.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/Converters.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsAlertsDBConverter.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsDatabase.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsRtAlerts.kt

app/src/main/java/it/reyboz/bustorino/fragments/AlertsDialogFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/AlertsFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/LinesGridShowingViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/LinesViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/ServiceAlertsViewModel.kt

app/src/main/res/drawable/chat_bubble_warning_solid.xml

app/src/main/res/drawable/refresh_line.xml

app/src/main/res/layout/entry_alert_line_adapter.xml

app/src/main/res/layout/fragment_alerts.xml

app/src/main/res/layout/fragment_dialog_alerts_line.xml

app/src/main/res/layout/fragment_dialog_buspositions.xml

app/src/main/res/layout/fragment_lines_detail.xml

app/src/main/res/values-it/strings.xml

app/src/main/res/values/dimens.xml

app/src/main/res/values/strings.xml

Download GTFS RT Alerts and show them in the lines screen
ClosedPublic
Actions

Revision Contents
Changeset List