Project Tags

Referenced Files

None

Subscribers

rosto

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

Libre BusTO hackers

Maniphest Tasks

T1437: Fix no favorites when DB is updating
T1434: Fix illegible SnackBar on the MainScreenFragment
T1439: Fix backup not working

Commits

R4:ab06076a77c5: Fix many bugs in map, favorites and snackbar, revise and modernize DB

Summary

Fix location handle not released

Fix snackbar text color

Rewrite many parts of the database to produce LiveData directly

Close the app after back press

Fix T1439

Fix T1434

Fix T1437

Diff Detail

Repository

R4 Libre BusTO

Branch

arcpatch-D239

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 878
Build 1285: BusTO Build Plan
Build 1284: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Tue, May 12, 19:53

Restricted Application added a project: Libre BusTO. · View Herald TranscriptTue, May 12, 19:53

Restricted Application added a reviewer: Libre BusTO hackers. · View Herald Transcript

Restricted Application added a subscriber: valerio.bozzolan. · View Herald Transcript

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D239-arm64-v8a-signed.apk
sha256: 239f3c1b2c71988aad7ca59dca9ab32735a11efd227c9065e8511de3790d1d44

APK for armeabi-v7a: D239-armeabi-v7a-signed.apk
sha256: e1fe3ee4f22d500b9d58dffb698b88c5863b75a1198c2b06c7e8c73ac850dbdd

APK for universal: D239-universal-signed.apk
sha256: 6d7e7da5cf7c11f90f59a461903fa1d4d7f2957142b60a5552ed6450bbe860cf

APK for x86: D239-x86-signed.apk
sha256: dcebeede106a4be364c3c1a50083582f9331db3fe8bdccd30646571cd15a81c8

APK for x86_64: D239-x86_64-signed.apk
sha256: 166fc5bbe7f71ba9ce89ece54d10611c362f12c41f196437dc5dca7228558573

Harbormaster completed remote builds in B874: Diff 745.Tue, May 12, 19:58

fabio.mazza requested review of this revision.Tue, May 12, 19:58

The issue with favorites is not resolved yet

fabio.mazza edited the summary of this revision. (Show Details)Tue, May 12, 20:04

fabio.mazza added tasks: T1439: Fix backup not working, T1436: Fix crash on map caused by LocationComponentNotInitializedException in MapLibreFragment.kt:491 on version 2.5.1-gitdev (probably related with the "Undo" action in the map).

fabio.mazza edited the summary of this revision. (Show Details)

fabio.mazza added a task: T1434: Fix illegible SnackBar on the MainScreenFragment.

fabio.mazza removed a task: T1436: Fix crash on map caused by LocationComponentNotInitializedException in MapLibreFragment.kt:491 on version 2.5.1-gitdev (probably related with the "Undo" action in the map).

Make all public methods in UserDB non static, add class to produce LiveData
Rewrite NextGenDB code with table notify, simplify
Do not use Content Resolver bulk insert
Use new LiveData in Favorites
Close the app after back press
Use new LiveData in arrivals too
Fix layout for nearby fragment

fabio.mazza retitled this revision from Start and stop location updates in NearbyStopsFragment to Fix many bugs in map, favorites and snackbar, revise and modernize DB.Wed, May 13, 15:43

fabio.mazza edited the summary of this revision. (Show Details)

fabio.mazza added a task: T1437: Fix no favorites when DB is updating.

fabio.mazza edited the summary of this revision. (Show Details)

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D239-arm64-v8a-signed.apk
sha256: 5275b9ec6354a9d9d7765bda7286056535d5d0de8049e2742dca5ba1d27060d0

APK for armeabi-v7a: D239-armeabi-v7a-signed.apk
sha256: 9d8fa7769863ba732ecfa6e8f209d0d57b2d05738ac603155ce7d15993ee86ec

APK for universal: D239-universal-signed.apk
sha256: e375e3b0fd7777180c6743aa9d3c1faaf340f2261fbd75da14861b35ae2ffb34

APK for x86: D239-x86-signed.apk
sha256: 2400a194aaaa7dd36d3e2d2dc7dcbcbcf8a765f15ce861a77dcf79d7c12bd764

APK for x86_64: D239-x86_64-signed.apk
sha256: 883669719c5130314c418d892ee1d1f6361732022dfe87d56c0f684874ac723a

Harbormaster completed remote builds in B875: Diff 746.Wed, May 13, 15:47

LOL immediate crash

Will share the stack trace

This revision now requires changes to proceed.Wed, May 13, 15:52

Fuck. I'm stupid and I've not sent the crash. So I guess nobody can triage my crash anymore and I cannot reproduce the crash anymore. I've installed old version, used it, and installed this version, still no crash.

I've re-installed 3 versions before, done tutorial, add stuff in favorites; installed this version, clicked every single button. No crashes. Map works. Arrivals work. MQTT MaTO works. Tried a force database upgrade and visited favorites: it works.

Yeah asd

This revision is now accepted and ready to land.Wed, May 13, 16:12

P.S. I've also clicked "Undo" 1000000 times and now it works lol

Fix crash

This revision now requires review to proceed.Wed, May 13, 19:37

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D239-arm64-v8a-signed.apk
sha256: 0ea3bf9b4400d3fd62b997121bdbd04db01e18de52e5c1856c26b3636ddff7e8

APK for armeabi-v7a: D239-armeabi-v7a-signed.apk
sha256: cb18c8068718b5aa8e052bbe6d351238fb7ee35ac64ebde05b6be4afd9e76f9a

APK for universal: D239-universal-signed.apk
sha256: 39b5b9dd16e079209950bff3e5c5ff1962580546b1e008e428372d9915c709e6

APK for x86: D239-x86-signed.apk
sha256: af55be58d1d05c060417b32968738e450f713e0aded07cb6c3278785019440f8

APK for x86_64: D239-x86_64-signed.apk
sha256: 3f96c531e201d3be0652f811d5a4a49cfe2f6694aa4c7e975e0a76f585b05846

Harbormaster completed remote builds in B876: Diff 747.Wed, May 13, 19:42

Remove
Fix lateinit property bug

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D239-arm64-v8a-signed.apk
sha256: e0c756eb27f19c1f740889a50b31f00fa8d953f485ddd7c1091204914ad37361

APK for armeabi-v7a: D239-armeabi-v7a-signed.apk
sha256: 4b637dfcf373435e32bb39b7ecbe88c405b63c5ff77632c9771b652c4e85b353

APK for universal: D239-universal-signed.apk
sha256: 8d74017092c99bb09289ffc4f36e3a7a779d6e3c980f73f55f5b3aa8e392c140

APK for x86: D239-x86-signed.apk
sha256: 165c1ba6b5137565e3896d0205a0d22cec1a87aa1ace88e608145e6ff94c5511

APK for x86_64: D239-x86_64-signed.apk
sha256: 998a6b5b4b9bda328c54636157d87fb9fa59883d5e054b5b95658ef9c0a36092

Harbormaster completed remote builds in B877: Diff 748.Wed, May 13, 23:59

Fix another bug caught by @rosto
Last finishing touches
Load all stops in the MapViewModel
Use new LiveData for the stops loaded from the DB
Move code to avoid crash (dammit!)

Fix fix

Harbormaster failed remote builds in B878: Diff 749!Thu, May 14, 01:20

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D239-arm64-v8a-signed.apk
sha256: cddce408cc3b7a30439e2611a6f26cba2ebd7beabf87832a978314675f4ea2c5

APK for armeabi-v7a: D239-armeabi-v7a-signed.apk
sha256: 16087f26e8eab880310ee853eaa0bef4ca862cb94d39396382b0f0943636d0a3

APK for universal: D239-universal-signed.apk
sha256: f5155973ec403fbd283d4bbb23fad327c617bead2942b701a6eb85dea06f9b5e

APK for x86: D239-x86-signed.apk
sha256: 015c74a6ef8efcd747560dfc4b4fc1daffff3871b05012b6b1a4b4c6ee060472

APK for x86_64: D239-x86_64-signed.apk
sha256: 31ec396c62b8b46025b3e9a7a7e67fb438011e7732c30920240a06a686cfb5d0

Harbormaster completed remote builds in B879: Diff 750.Thu, May 14, 01:25

Surround with try catch so that the app doesn't crash (it's useless)

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D239-arm64-v8a-signed.apk
sha256: 56ac7d5af97c8ef94bbd0c89f8af137eb7a9d87bf6a846805a2406f310ced17b

APK for armeabi-v7a: D239-armeabi-v7a-signed.apk
sha256: a2a5b959fc203f5e93870a1fb54417965bb2c9d6343e537fdf91da73cc4a7a53

APK for universal: D239-universal-signed.apk
sha256: 90903e027ed004d6eea746193f255b179a8ca4245db65f5020d88a5db25606b9

APK for x86: D239-x86-signed.apk
sha256: 013e62612015639d5f9c49a8c353e845faead0259d82c31d695994aae354fac5

APK for x86_64: D239-x86_64-signed.apk
sha256: bc053b33a11cfc0bd3e265f7785fe99a712146eb6a0aedde8dcb866aeb6f723e

Harbormaster completed remote builds in B880: Diff 751.Thu, May 14, 12:24

search 1254
map, mqtt
favorites, add favorites
lines, add favorite line
undo multiple times
app background, foreground

This revision is now accepted and ready to land.Thu, May 14, 12:32

Closed by commit R4:ab06076a77c5: Fix many bugs in map, favorites and snackbar, revise and modernize DB. · Explain WhyThu, May 14, 12:35

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:ab06076a77c5: Fix many bugs in map, favorites and snackbar, revise and modernize DB.

fabio.mazza mentioned this in T1436: Fix crash on map caused by LocationComponentNotInitializedException in MapLibreFragment.kt:491 on version 2.5.1-gitdev (probably related with the "Undo" action in the map).Sat, May 16, 20:01

Fix many bugs in map, favorites and snackbar, revise and modernize DB
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 749

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

app/src/main/java/it/reyboz/bustorino/backend/Result.java

app/src/main/java/it/reyboz/bustorino/backend/StopFavoritesData.kt

app/src/main/java/it/reyboz/bustorino/data/AppDataProvider.java

app/src/main/java/it/reyboz/bustorino/data/DBUpdateWorker.kt

app/src/main/java/it/reyboz/bustorino/data/DatabaseUpdate.java

app/src/main/java/it/reyboz/bustorino/data/FavoritesLiveData.java

app/src/main/java/it/reyboz/bustorino/data/FavoritesViewModel.java

app/src/main/java/it/reyboz/bustorino/data/InvalidationTracker.kt

app/src/main/java/it/reyboz/bustorino/data/NextGenDB.java

app/src/main/java/it/reyboz/bustorino/data/OldDataRepository.kt

app/src/main/java/it/reyboz/bustorino/data/QueryLiveData.kt

app/src/main/java/it/reyboz/bustorino/data/UserDB.java

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/BackupImportFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/FavoritesFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/GeneralMapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/MapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/NearbyStopsFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/ResultListFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

app/src/main/java/it/reyboz/bustorino/middleware/AppLocationManager.kt

app/src/main/java/it/reyboz/bustorino/middleware/AsyncArrivalsSearcher.java

app/src/main/java/it/reyboz/bustorino/middleware/AsyncStopFavoriteAction.java

app/src/main/java/it/reyboz/bustorino/middleware/CoroutineFavoriteAction.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/ArrivalsViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/FavoritesViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/LinesViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/StopsMapViewModel.kt

app/src/main/res/layout/fragment_main_screen.xml

app/src/main/res/layout/fragment_nearby_stops.xml

app/src/main/res/values/strings.xml

Fix many bugs in map, favorites and snackbar, revise and modernize DBClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 749

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

app/src/main/java/it/reyboz/bustorino/backend/Result.java

app/src/main/java/it/reyboz/bustorino/backend/StopFavoritesData.kt

app/src/main/java/it/reyboz/bustorino/data/AppDataProvider.java

app/src/main/java/it/reyboz/bustorino/data/DBUpdateWorker.kt

app/src/main/java/it/reyboz/bustorino/data/DatabaseUpdate.java

app/src/main/java/it/reyboz/bustorino/data/FavoritesLiveData.java

app/src/main/java/it/reyboz/bustorino/data/FavoritesViewModel.java

app/src/main/java/it/reyboz/bustorino/data/InvalidationTracker.kt

app/src/main/java/it/reyboz/bustorino/data/NextGenDB.java

app/src/main/java/it/reyboz/bustorino/data/OldDataRepository.kt

app/src/main/java/it/reyboz/bustorino/data/QueryLiveData.kt

app/src/main/java/it/reyboz/bustorino/data/UserDB.java

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/BackupImportFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/FavoritesFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/GeneralMapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/MapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/NearbyStopsFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/ResultListFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

app/src/main/java/it/reyboz/bustorino/middleware/AppLocationManager.kt

app/src/main/java/it/reyboz/bustorino/middleware/AsyncArrivalsSearcher.java

app/src/main/java/it/reyboz/bustorino/middleware/AsyncStopFavoriteAction.java

app/src/main/java/it/reyboz/bustorino/middleware/CoroutineFavoriteAction.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/ArrivalsViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/FavoritesViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/LinesViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/StopsMapViewModel.kt

app/src/main/res/layout/fragment_main_screen.xml

app/src/main/res/layout/fragment_nearby_stops.xml

app/src/main/res/values/strings.xml

Fix many bugs in map, favorites and snackbar, revise and modernize DB
ClosedPublic
Actions

Revision Contents
Changeset List