Project Tags

Referenced Files

	F14710510: D255.1788981350.diff
	Tue, Sep 8, 21:15

	F13827214: Screenshot_20260901-081342_BusTO git.png
	Tue, Sep 1, 08:18

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

Libre BusTO hackers

Maniphest Tasks

T1425: Show GTFS Alerts about a line also inside the Stop

Summary

Adjust layout

Fix T1425

Diff Detail

Repository

R4 Libre BusTO

Branch

gtfsstop

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 977
Build 1460: BusTO Build Plan
Build 1459: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Jun 4 2026, 19:59

Restricted Application added a project: Libre BusTO. · View Herald TranscriptJun 4 2026, 19:59

Restricted Application added a reviewer: Libre BusTO hackers. · View Herald Transcript

Restricted Application added a subscriber: valerio.bozzolan. · View Herald Transcript

I'm not too happy with the result. I think the alerts should be shown separately for each line.

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D255-arm64-v8a-signed.apk
sha256: 0bd90104fd61d12c8aaa416b78a133edc01946b18b0f112ea880ee984c574671

APK for armeabi-v7a: D255-armeabi-v7a-signed.apk
sha256: 6f3a305bb3fdb881ef7cf1db06bad66e08bc274c3147fb04e58c384f8d2e6031

APK for universal: D255-universal-signed.apk
sha256: ec358101a97facf2422405a357842bebad6f2a4f7b8079c80e0a1690bc2ba5dc

APK for x86: D255-x86-signed.apk
sha256: 92afb4dda8913d0aafc0b72adc9fbf08aa7e0f64b5b55f5fbe27d21a63a530fd

APK for x86_64: D255-x86_64-signed.apk
sha256: e31d0a97336b8e86d0f3e0a9a47bedfe548f4e5636a3e70ca260214342d5c0f3

Harbormaster completed remote builds in B974: Diff 838.Jun 4 2026, 20:04

fabio.mazza requested review of this revision.Jun 4 2026, 20:04

Rename .java to .kt
Rewrite PalinaAdapter in Kotlin
Show alerts from adapter

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D255-arm64-v8a-signed.apk
sha256: f4230d37194dfe2d18118a501026de5afd8017e5467978a0fc8760424e453205

APK for armeabi-v7a: D255-armeabi-v7a-signed.apk
sha256: c1c0bf7b7abf74296eb4d02528edcd372e0b0d233460bcc5cadb3e4cef2cec10

APK for universal: D255-universal-signed.apk
sha256: cfeb08507bd4b0643aef4c9bf56ebed1e33cb377a4644d05a86c247d3dfba5de

APK for x86: D255-x86-signed.apk
sha256: 332872298d0c039ec69d91937ff768781fceebf435762039c86f16a88b821cea

APK for x86_64: D255-x86_64-signed.apk
sha256: d201a31888e80c2ed317c2905d96f6a710c23e7cfa1da4b95578d2195cf444fb

Harbormaster completed remote builds in B975: Diff 839.Jun 5 2026, 17:37

Show alerts also for arrival sources without gtfs route id
Add image
Use material cardview

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D255-arm64-v8a-signed.apk
sha256: c918551cbf6e47b7f75fc99ff3912b6e1c124000d68ffd6553fe62cc4f12fcc0

APK for armeabi-v7a: D255-armeabi-v7a-signed.apk
sha256: 46cd1e8cfa4392cab4048a90e5696d3f98dfc672ddf6b43bb043a67db35dfb54

APK for universal: D255-universal-signed.apk
sha256: cc6d4efe49ed213156d4214b964ec57a532b1faa6a3b22b5cd9d085f45793b16

APK for x86: D255-x86-signed.apk
sha256: 6c18fe1ce50b71f2f67b40dcab4f6d5e7bd619b3feada4687427f57b7ffbb51f

APK for x86_64: D255-x86_64-signed.apk
sha256: 029e3823042fc9beca448d9caddfc72d0e4ff35f46419a1ff3c3c1760966d27a

Harbormaster completed remote builds in B976: Diff 840.Jun 5 2026, 21:37

Is there a nice task about this? :3

fabio.mazza edited the summary of this revision. (Show Details)Jun 6 2026, 09:49

fabio.mazza added a task: T1425: Show GTFS Alerts about a line also inside the Stop.

Enlarge title in preferences, create setting for URL for GTFS data

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D255-arm64-v8a-signed.apk
sha256: 9256bb9f7f06efcdd3869376c080797535c85175176bc0f46cc74a5ec0a1fe4c

APK for armeabi-v7a: D255-armeabi-v7a-signed.apk
sha256: 6a142c8fa37dd82dffbced51c620c1a102ccb444d2dd58811585d3a889b52d69

APK for universal: D255-universal-signed.apk
sha256: 59383fbacddcd7caa51d9a826f90d52658f6d121e839352648b42703993be733

APK for x86: D255-x86-signed.apk
sha256: cb5b7770723e5fc7281b7c2cdc994a050f5597c518963a06e204f72882659d94

APK for x86_64: D255-x86_64-signed.apk
sha256: 9a4fa2fabab27f0feaabc23187e40da845e65c0027343e3b79acdf602b2d0249

Harbormaster completed remote builds in B977: Diff 841.Jun 8 2026, 19:20

Fix visualization issue in NearbyStopsFragment

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D255-arm64-v8a-signed.apk
sha256: 36a4396b58559a85484b640cd5d1fa488e24e4529f3b17653b095c879b030141

APK for armeabi-v7a: D255-armeabi-v7a-signed.apk
sha256: 01bcfd01c46d85b4facd2d33491a80d48e805b4ecb00bb2380ccddf20f94ef4d

APK for universal: D255-universal-signed.apk
sha256: a1bc3110a4374e47738cd0d74e7a597534bc503c2867e83ea4566f1ca65c1d51

APK for x86: D255-x86-signed.apk
sha256: ff1eb83d9880363aac4f53cf5c0a77ae0587905a3c7736ba9385b430f1ab3228

APK for x86_64: D255-x86_64-signed.apk
sha256: 8082dcfee066a63a8b80a2bd7128d7d74b91ae2446b947c00e4b8ad55787cb89

Harbormaster completed remote builds in B978: Diff 842.Jun 10 2026, 20:21

Nice! Is it possible here to easily see+copy the default?

Screenshot_20260901-081342_BusTO git.png (1,224×2,700 px, 159 KB)

The simplest solution I can think about:

show the default value as value, instead of an empty input
on save, promote the default to null again

Sorry for gatekeeping this proposal for this silly reason, but I'm concerned that otherwise it's too difficult to understand what's happening and how to test the URL manually etc. - thanks 🥰

P.S. if you want a free pizza and free beer, tonight I'm @ Torino lol

This revision now requires changes to proceed.Tue, Sep 1, 08:18

Download GTFS stops table from github. Show alerts in line. Fix DB update problem
Needs RevisionPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 841

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

app/src/main/java/it/reyboz/bustorino/adapters/PalinaAdapter.java

app/src/main/java/it/reyboz/bustorino/adapters/PalinaAdapter.kt

app/src/main/java/it/reyboz/bustorino/backend/utils.java

app/src/main/java/it/reyboz/bustorino/data/DBUpdateCheckWorker.kt

app/src/main/java/it/reyboz/bustorino/data/DBUpdateWorker.kt

app/src/main/java/it/reyboz/bustorino/data/FavoritesLiveData.java

app/src/main/java/it/reyboz/bustorino/data/GtfsRepository.kt

app/src/main/java/it/reyboz/bustorino/data/PreferencesHolder.java

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsDBDao.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsRoute.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsStop.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsTable.java

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsTableJsonInserter.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/RecordInserter.kt

app/src/main/java/it/reyboz/bustorino/fragments/AlertsDialogFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/SettingsFragment.java

app/src/main/java/it/reyboz/bustorino/viewmodels/ArrivalsViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/ServiceAlertsViewModel.kt

app/src/main/res/layout/entry_alert_line_adapter.xml

app/src/main/res/layout/entry_bus_line_passage.xml

app/src/main/res/layout/fragment_arrivals.xml

app/src/main/res/layout/title_preferences_custom.xml

app/src/main/res/menu/menu_arrivals_line_item.xml

app/src/main/res/values-it/strings.xml

app/src/main/res/values/strings.xml

app/src/main/res/xml/preferences.xml

Download GTFS stops table from github. Show alerts in line. Fix DB update problemNeeds RevisionPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 841

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

app/src/main/java/it/reyboz/bustorino/adapters/PalinaAdapter.java

app/src/main/java/it/reyboz/bustorino/adapters/PalinaAdapter.kt

app/src/main/java/it/reyboz/bustorino/backend/utils.java

app/src/main/java/it/reyboz/bustorino/data/DBUpdateCheckWorker.kt

app/src/main/java/it/reyboz/bustorino/data/DBUpdateWorker.kt

app/src/main/java/it/reyboz/bustorino/data/FavoritesLiveData.java

app/src/main/java/it/reyboz/bustorino/data/GtfsRepository.kt

app/src/main/java/it/reyboz/bustorino/data/PreferencesHolder.java

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsDBDao.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsRoute.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsStop.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsTable.java

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsTableJsonInserter.kt

app/src/main/java/it/reyboz/bustorino/data/gtfs/RecordInserter.kt

app/src/main/java/it/reyboz/bustorino/fragments/AlertsDialogFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/SettingsFragment.java

app/src/main/java/it/reyboz/bustorino/viewmodels/ArrivalsViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/ServiceAlertsViewModel.kt

app/src/main/res/layout/entry_alert_line_adapter.xml

app/src/main/res/layout/entry_bus_line_passage.xml

app/src/main/res/layout/fragment_arrivals.xml

app/src/main/res/layout/title_preferences_custom.xml

app/src/main/res/menu/menu_arrivals_line_item.xml

app/src/main/res/values-it/strings.xml

app/src/main/res/values/strings.xml

app/src/main/res/xml/preferences.xml

Download GTFS stops table from github. Show alerts in line. Fix DB update problem
Needs RevisionPublic
Actions

Revision Contents
Changeset List